Testing 1: Migration

Submitted by Admin on Thu, 06/02/2022 - 13:06

The first and most important goal of the upgrade is to make sure we don't lose any information as it is migrated from the old site.

Please could you help to check some of the pages you are familiar with, then leave a comment below to let us know what content type you checked (eg Photo, Place, etc.) and if you found any problems. If your screen is wide enough, it can help to have a copy of the same page in both gwulo.com and new.gwulo.com open at the same time, to make it easy to compare them.

If we find any serious problems with the migration there's a chance it will have to be run again, losing any new content on this site. So though you are welcome to test adding to the site, I suggest you don't add very much until we're happy the migration has worked.

It looks like the auto generated lists and maps inserted into the Gweilo locations chapters didn't migrate:
https://new.gwulo.com/node/2306
https://new.gwulo.com/node/2307
https://new.gwulo.com/node/2308
https://new.gwulo.com/node/2309
https://new.gwulo.com/node/2310
https://new.gwulo.com/node/2311
https://new.gwulo.com/node/2312
https://new.gwulo.com/node/2313
https://new.gwulo.com/node/2314

I've checked a few place links and they seem to be intact, just the list and maps are the issue.

The same thing has ahppened to these pages:
https://new.gwulo.com/node/3013
https://new.gwulo.com/node/3018
(and the rest I assume - main page linking them all is here: https://new.gwulo.com/node/2931)

Unfortunately they can't be migrated automatically, so I'll need to:

  1. make new 'views' that produce the maps and lists 
  2. then all the pages will need to be updated to use those new views

 

Fortunately there are only a few different versions of the views mentioned in (1), so once each one is written it can be used on several pages.

It looks like around 100 pages will need updating: https://new.gwulo.com/search?query=php%20view

I've added a profile photo for Tphoon Rose - works!
I've edited Gutzlaff Street Public Toilet and Bathhouse [1949-c.2018]. It works for the outline of the building (outline on the map). The text explaining this place is not accessible for editing.

My written piece on the Old Houses of Kowloon Tong (https://new.gwulo.com/node/39430) is missing, but the comments and other people's photos are visible. There is no code text or anything else in place of the written piece - it just goes straight to the comments.
I've checked my Industrial Heritage forum topic - no problems there.
I've also checked several place pages and have not noticed any issues.

Hi David,

yes, editing is possible now. When I click "Edit", the following text appears (example):

Was located at the Junction of Gutzlaff Street and Chuk Hing Lane, Central District, opened in 1949. It was a two-story building which covered an area of 190 m2, ground floor for male, and first floor for female users. It had a rectangular shape with the smaller side facing Gutzlaff Street. It’s shown on the 1975 map below:

1975-09 map of the Gutzlaff Street Area, by hkms2.0

The map doesn't appear here, nor do other images? Intended or bug?

regards, Klaus

P.S. Besides initial problems, the new website looks really good, although still a bit unfamiliar.

1. Edited the photo caption of 1930s Fenwick Street at https://new.gwulo.com/media/42988  No problems.

2. Edited and reviewed Colonial Postboxes at https://new.gwulo.com/colonial-postboxes-in-hong-kong  However, the Harbour Office postbox photo is missing as copied hereunder:

Re: Harbour Office Postbox - Hong Kong's first pillar box

Permalink

 Submitted by 

moddsey

 on 

Tue, 12/11/2018 - 11:26

In reply to Hong Kong pillar boxes: 1878 - 1910 by whitto

A photo of the Harbour Master's Office (1866-1906). Postbox from 1878 viewed from Wing Lok Street.

ERROR: FilterGwulo.php missed D7 image macro

1880s Harbour Master's Office, by Moddsey

 

 

Time permitting, suggest to add a link to the Harrison Forman photos under "Popular" with a suggested title "1940-41: Harrison Forman's photos" . Allows easier access to the photos.

Embedded images aren't shown when editing

yes, editing is possible now. When I click "Edit", the following text appears (example):

Was located at the Junction of Gutzlaff Street and Chuk Hing Lane, Central District, opened in 1949. It was a two-story building which covered an area of 190 m2, ground floor for male, and first floor for female users. It had a rectangular shape with the smaller side facing Gutzlaff Street. It’s shown on the 1975 map below:

1975-09 map of the Gutzlaff Street Area, by hkms2.0

The map doesn't appear here, nor do other images? Intended or bug?

 It is a temporary bug.

The embedded images from the old site work by adding codes like this into the text:

<div class="dnd-atom-wrapper" data-scald-align="none" data-scald-context="sdl_editor_representation" data-scald-options="%20%7B%22link%22%3A%22http%3A%2Fatom%2F42688%22%7D" data-scald-sid="42688" data-scald-type="image">
<div class="dnd-caption-wrapper">
<div class="meta"><!--copyright=42688-->1975-09 map of the Gutzlaff Street Area, by hkms2.0<!--END copyright=42688--></div>
</div>

But the new site doesn't know what they mean.

So whenever the new site displays a page, I convert the above codes into a format that the new site understands, and so the image is displayed. That doesn't work in the editor, which is why you just see the image's caption.

The good news is that once my converter is able to cope with all of the different types of embedded images (i.e. when we no longer see any of these errors - ERROR: FilterGwulo.php missed D7 image macro), then I can permanently convert all the codes that are stored in the database. Then you'll see the images in bot the editor and on the displayed page.

Created a photo at http://new.gwulo.com/media/43050 via smartphone.

A few observations:

1. Getting the hang of finding and adding the location of the photo under “Additional Information”. Suggest for clarity and easier instruction of including location(s) etc to photos by adding next to “Additional Information: Locations, (etc), Tags”. At present only “Tags” are presented.

2. In the past configuration, one could differentiate the source of the photo under Author (e.g. Flickr contributor, Museum, University etc and the photo Submitter. The former provided an acknowledgement of the photo source. Not sure but it appears now that the “Author”and “Submitted by (person)” are one and the same. May not always be the same due to various reasons e.g. copyright etc 

(Update to 2. Recently submitted a Flickr photo giving the Author's name and original source. Doubts dispelled. The new configuration works the same as the old one. )

3. Suggest under “When was this photo taken” to add in the last line “date or estimated date”  as it provides the opportunity for the Submitter to make an assessment of when the photo was taken and for contributors/viewers to narrow down the date or time frame.

(Update to 3. on dating photos. Been playing around with the date options. I see what “on the date” means. At first glance, I thought it meant the actual date but options are given, the same as in the old format.)

 

The old website had an optional spell corrector (SCAYT if I remember correctly). This would be helpful also for the new website.

Thanks for trying out adding new photos, and for the feedback.

1. “Additional Information”. 

I'll keep the current short title, so it fits on one line on mobile screens. (The idea of hiding some of the information away under "Additional information" is to see if we can make uploading photos less intimidating for new contributors.)

I'll need to update the tutorials to explain what is under "Additional Information" to advanced users.

I never knew we had a spell-checker on the old site! But I went back and checked and you are absolutely right. I've updated the new site to have the same SCAYT spell-checker.

I've found the following issues with some of my posts.

1. node/58642 contains a sentence within the text, saying "Error.....has matched too many divs", which was not in the original.

2. node/18374 is a post containing numerous photos, many of which have been flipped 90 degrees in the new version.

3. media/19269. The photo that should appear at the start of the post is missing.

4. node/17146. This is the "Place" page for Wanchai Gap AOP. The "Photos that show this place" part contains a number of unrelated photos, but not the ones related to this place.

5. media/25444. The photo is missing.

Thanks for the feedback.

1. node/58642 contains a sentence within the text, saying "Error.....has matched too many divs", which was not in the original.

Fixed now, though the error message is still shown on 20-30 other pages (see https://new.gwulo.com/search?query=filtergwulo.php). These pages have some quirks where my automatic converter isn't able to update the embedded images to the new format, so they will have to be updated manually. 

2. node/18374 is a post containing numerous photos, many of which have been flipped 90 degrees in the new version.

Noted as a bug for further investigation. (I guess these are photos that were taken with an iPhone? It has special handling for rotated photos. I'd tested that after uploading a new rotated photo from an iPhone it displays correctly, but it looks as though that didn't work with migrated photos.)

3. media/19269. The photo that should appear at the start of the post is missing.

Noted as a bug for further investigation. (It is a Flickr image. I guess it is one where the photo has been deleted from Flickr at some point after it was added to Gwulo.)

4. node/17146. This is the "Place" page for Wanchai Gap AOP. The "Photos that show this place" part contains a number of unrelated photos, but not the ones related to this place.

Noted as a bug for further investigation. (The problem is not with the Place page, but with the media pages, eg https://new.gwulo.com/media/20009. First investigations show that the photo shown there (the group of old ladies) and the correct photo of the Wanchai Gap AOP both have the same filename, and so they've got mixd up during the migration.)

5. media/25444. The photo is missing.

This is also a Flickr photo, so it is another example of problem 3 above.

On the old Gwulo website, it was possible to add places to photos of other contributors. This is missing on the new one. Probably already on your to-do list.

4. node/17146. This is the "Place" page for Wanchai Gap AOP. The "Photos that show this place" part contains a number of unrelated photos, but not the ones related to this place.

This bug should now be fixed. It affected several other pages too.

Note that if you still see the wrong photos when you visit that page, please try clearing browsing data in your web browser. I had to do that before I could see the correct photos.

This fix also needs all of the zoom tiles to be re-built, so you may not be able to use the zoom tab on images for the next few hours.

All the embedded images that were in posts and comments should now display their images correctly.

If you still see any pages with text like this, please let me know as it should have been converted to show an image:

[img_assist|nid=6439|title=|desc=|link=node|align =center|width=318|height=320 ]

I've noticed the date format on the site is defaulted to US style - mm/dd/yyyy

any chance of setting it to dd/mm/yyyy? or is it a local thing to my browser? 

The old website had additional features for editing comments, e.g. "insert as plain text, etc". I'm also missing the "undo" button.

Please could you let me know which page you were working on that had the mm/dd/yyyy date format?

The goal is to use dd/mm/yyyy

I've added the extra buttons.

I've also turned off spell-check by default, as it slows down loading pages. The spell-check feature is still available, you just need to click the button and enable it when you want to use it.

Thanks Phil. I'd been so concentrated on dealing with the dates we add to photos, people, etc,, I'd overlooked the 'submitted by' dates. I'll add that to the to-do list.

When testing "Broadwood Terrace" under "Places" I got the following error message when I attempted to cite the Gwulo link to the photos of same that I had previously uploaded:

ERROR: FilterGwulo.php with caption has matched too many divs

I couldn't find "Broadwood Terrace (2)" by means of the Search Window - only "Broadwood Terrace (1)"

I should eventually like to edit the date, as it looks as if the map is from 2015, whereas 2015 was the date that I took the photo.

Adding a profile photo is a bit tricky. You have to find the chosen image as you need the exact title, and you have to click on "image" (when it was uploaded to Gwulo from someone's computer) or on "Flickr" (when it was uploaded from there). 

Usually, the profile image is one of the photos attached to a place etc.  It would be helpful if all images would be shown by default (and only these) when a profile photo is to be selected.

ERROR: FilterGwulo.php with caption has matched too many divs

I've tidied up the comment at https://new.gwulo.com/comment/64364#comment-64364 to fix that.

I couldn't find "Broadwood Terrace (2)" by means of the Search Window - only "Broadwood Terrace (1)"

The second photo was uploaded with a different name: https://new.gwulo.com/search?query=broadwood_terrace_2.jpg

I should eventually like to edit the date, as it looks as if the map is from 2015, whereas 2015 was the date that I took the photo.

That is working, so when you're ready you can visit the image page, eg https://new.gwulo.com/media/42990, and edit it to change the date.

I agree it will be helpful to have the option to see all the photos attached to a Place, and choose one of them as the profile photo.

I'm not sure how easy it is to make that happen, but it will be something to look at once all the bugs are fixed.

Forgot to say that I like the new default map (HK Government Map)  better than the ESRI map used for the old website. The new one reveals more details compared to ESRI map. Also the new satelite map looks better than the one from Google. 

Tried loading a Flickr image at: https://flickr.com/photos/61170309@N08/11262591434/in/album-72157634541… but could not. The following text appeared:

Warning: md5_file(public://media-icons/generic/flickr.png): failed to open stream: "Drupal\Core\StreamWrapper\PublicStream::stream_open" call failed in _gwulo_zoom_identical() (line 147 of modules/contrib/gwulo_zoom/gwulo_zoom.inc).

_gwulo_zoom_identical(Object, 162674, 'public://media-icons/generic/flickr.png') (Line: 337) _gwulo_zoom_update_media(Object) (Line: 53) gwulo_zoom_media_update(Object) call_user_func_array(Object, Array) (Line: 426) Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'gwulo_zoom') (Line: 405) Drupal\Core\Extension\ModuleHandler->invokeAllWith('media_update', Object) (Line: 433) Drupal\Core\Extension\ModuleHandler->invokeAll('media_update', Array) (Line: 249) Drupal\Core\Entity\EntityStorageBase->invokeHook('update', Object) (Line: 903) Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('update', Object) (Line: 598) Drupal\Core\Entity\EntityStorageBase->doPostSave(Object, 1) (Line: 784) Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object, 1) (Line: 523) Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 802) Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 29) Drupal\media\MediaStorage->save(Object) (Line: 339) Drupal\Core\Entity\EntityBase->save() (Line: 285) Drupal\Core\Entity\EntityForm->save(Array, Object) (Line: 61) Drupal\media\MediaForm->save(Array, Object) call_user_func_array(Array, Array) (Line: 114) Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52) Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 592) Drupal\Core\Form\FormBuilder->processForm('media_flickr_edit_form', Array, Object) (Line: 320) Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73) Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39) Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object) call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 564) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 158) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23) Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 709) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

 

Unfortunately this reveals a bigger problem, as I see that the software we use to handle Flickr images is no longer supported, as it has a security risk (see https://www.drupal.org/project/media_entity_flickr). 

I believe that the risk applies when adding new Flickr images to Gwulo, not when viewing existing Flickr images. So I've disabled the ability to add more Flickr images, though previously created Flickr images remain visible.

If the security problem is fixed in future, I'll enable adding Flickr images again.

In the meantime, if the Flickr user allows downloads it is still possible to download a copy of the Flickr image and then upload it to Gwulo as we would with one of our own image files. I recommend pasting the link to the Flickr image into the notes, and also putting the Flickr username into the Authors field on Gwulo, so it is clear where the image came from originally.

2. node/18374 is a post containing numerous photos, many of which have been flipped 90 degrees in the new version.

I'm not sure what caused these images to be rotated, and couldn't find an easy automated ay to fix them. I ended up going to each photo's page, downloading & rotating it, then replacing the original with the rotated copy. All fixed now.